Repository navigation
Bump cardano-api to 11.12.0 and add new protocol params in CLI options - #1497
Merged
Merged
Conversation
koslambrou
requested review from
a team,
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
palas
as code owners
November 5, 2026 15:50
koslambrou
marked this pull request as draft
November 5, 2026 15:50
palas
force-pushed
the
koslambrou/bump-cardano-api-11.12.0
branch
from
November 5, 2026 19:59
d689273 to
fb1da14
Compare
koslambrou
force-pushed
the
koslambrou/bump-cardano-api-11.12.0
branch
from
November 5, 2026 20:23
fb1da14 to
ec4bf89
Compare
koslambrou
marked this pull request as ready for review
November 5, 2026 20:24
koslambrou
force-pushed
the
koslambrou/bump-cardano-api-11.12.0
branch
3 times, most recently
from
November 5, 2026 20:32
dfd4a5b to
59cdb84
Compare
Bump cardano-api which adds ten fields to `IntroducedInDijkstraPParams`, and expose each of them on `governance action create-protocol-parameters-update`: ``` --min-pool-margin --max-pledge-leverage / --no-max-pledge-leverage --peras-min-candidate-block-age --peras-healing-factor --peras-cert-boost --peras-target-committee-size --peras-bootstrap-round / --no-peras-bootstrap-round --peras-quorum-threshold-safety-margin --ref-inputs-cost-per-multi-asset-policy --ref-inputs-cost-per-datum-byte ``` The max pledge leverage and Peras bootstrap round parameters are themselves optional, so the --no- flags propose setting them to "no value", which is distinct from leaving them out of the update. Extend the Dijkstra protocol parameters update golden test to set every new parameter, and regenerate the help golden files.
koslambrou
force-pushed
the
koslambrou/bump-cardano-api-11.12.0
branch
from
November 5, 2026 20:32
59cdb84 to
b8fcef3
Compare
palas
approved these changes
Nov 5, 2026
palas
left a comment
palas
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍. We could improve the errors for invalid values passed to the flags, which fail a bit abruptly for some values, but that is not just for this PR, so I am not blocking it for this reason.
16 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump cardano-api to 11.12.0, which adds ten fields to
IntroducedInDijkstraPParams, and expose each of them ongovernance action create-protocol-parameters-update:The max pledge leverage and Peras bootstrap round parameters are themselves optional, so the --no- flags propose setting them to "no value", which is distinct from leaving them out of the update.
Extend the Dijkstra protocol parameters update golden test to set every new parameter, and regenerate the help golden files.
Checklist
.changes/